Conversation
Palbolsky
reviewed
Aug 3, 2025
AerunDev
reviewed
Aug 3, 2025
AerunDev
approved these changes
Aug 3, 2025
Palbolsky
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes the showndown import process not working in some specific cases.
The array containing Pokémon that have an hyphen '-' in their name has been completed to avoid false positives on alternative forms.
The conversion to DbSymbol from a string has been completed to include usual special characters like ', : or .
The conversion also includes a normalization to remove accents from letters.
Note before testing
Here's a template to test different cases on:
Tests to perform