Skip to content

Fix showndown format import#558

Merged
AerunDev merged 2 commits intodevelopfrom
fix-showndown-import-util
Aug 28, 2025
Merged

Fix showndown format import#558
AerunDev merged 2 commits intodevelopfrom
fix-showndown-import-util

Conversation

@Aelysya
Copy link
Collaborator

@Aelysya Aelysya commented Aug 3, 2025

Description

This MR fixes the showndown import process not working in some specific cases.

The array containing Pokémon that have an hyphen '-' in their name has been completed to avoid false positives on alternative forms.

The conversion to DbSymbol from a string has been completed to include usual special characters like ', : or .
The conversion also includes a normalization to remove accents from letters.

Note before testing

Here's a template to test different cases on:

POKEMON_NAME
Ability: Overgrow
- King's Shield
- Land's Wrath

Tests to perform

  • Test the import process with Pokémon without special characters in their name, the importation still works correctly
  • Test the import process with Pokémon with special characters in their name, the importation works correctly (examples: Jangmo-o, Ho-oh, Type: Null, Farfetch'd, Mr. Mime)
  • Test the import process with moves with special characters in their name, the importation works correctly (examples are included in the template above)

@AerunDev AerunDev moved this from Backlog to In Review in Pokémon Studio Aug 3, 2025
@AerunDev AerunDev added the Bug Something isn't working label Aug 3, 2025
@AerunDev AerunDev merged commit cb1d152 into develop Aug 28, 2025
5 checks passed
@AerunDev AerunDev deleted the fix-showndown-import-util branch August 28, 2025 16:49
@github-project-automation github-project-automation bot moved this from In Review to Done in Pokémon Studio Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants