Conversation
Palbolsky
approved these changes
Sep 2, 2025
AntoinePoree
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a line to the migration that adds the contest data to moves.
This was done to prevent a known issue with the Gen 9 datapack that contains a file named differently from the db_symbol it contains, effectively duplicating it during the migration and causing the project to not be able to load due to the old file not being compliant with the Zod format.
Closes #650
Note before testing
In a pre-2.7.0 project, create a file named
kotow_cleavein your moves folder. Paste this content inside:{ "klass": "Move", "id": 902, "dbSymbol": "kowtow_cleave", "mapUse": 0, "battleEngineMethod": "s_basic", "type": "dark", "power": 85, "accuracy": 0, "pp": 10, "category": "physical", "movecriticalRate": 1, "priority": 0, "isAuthentic": false, "isBallistics": false, "isBite": false, "isBlocable": true, "isCharge": false, "isDance": false, "isDirect": true, "isEffectChance": false, "isGravity": false, "isHeal": false, "isKingRockUtility": true, "isMagicCoatAffected": false, "isMental": false, "isMirrorMove": true, "isNonSkyBattle": false, "isPowder": false, "isPulse": false, "isPunch": false, "isRecharge": false, "isSnatchable": false, "isSoundAttack": false, "isSlicingAttack": true, "isUnfreeze": false, "isWind": false, "battleEngineAimedTarget": "adjacent_pokemon", "battleStageMod": [], "moveStatus": [], "effectChance": 0, }Tests to perform
kotow_cleave.jsonhas been removedkowtow_cleave.jsonhas been correctly created