Skip to content

Fix texts in Select Components when no option is found#671

Merged
AerunDev merged 1 commit intodevelopfrom
fix-translation-keys-in-select-components
Oct 24, 2025
Merged

Fix texts in Select Components when no option is found#671
AerunDev merged 1 commit intodevelopfrom
fix-translation-keys-in-select-components

Conversation

@Aelysya
Copy link
Collaborator

@Aelysya Aelysya commented Oct 11, 2025

Description

This PR fixes some translation texts in the english version of Pokémon Studio.
When searching for entities that don't exist in a Select, the default text that appears was always "No ability found", regardless if the select was for abilities or not.
The issue was less visible in french because the default text was "Aucun résultat trouvé" in every case.
Their is also a quick fix on the Experience curve "Normal" for Pokémon that was incorrectly showing a critical ratio text (the key used was "normal" instead of "normal_experience_curve")

Tests to perform

  • Test every Select Component in the app that allows typing, with random letters in order to make the "No XXX found" appear (where XXX is the current entity name). They should all show a correct text
  • Set a Pokémon to have the "Medium Fast" experience curve, the text shown in it's datablock is correct

@Aelysya Aelysya self-assigned this Oct 11, 2025
@AerunDev AerunDev moved this from Backlog to In Review in Pokémon Studio Oct 11, 2025
@AerunDev AerunDev added the Bug Something isn't working label Oct 11, 2025
Copy link
Collaborator

@AntoinePoree AntoinePoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu pour le changements aux multiples endroits Aelysya !

@AerunDev AerunDev merged commit 058bfeb into develop Oct 24, 2025
5 checks passed
@AerunDev AerunDev deleted the fix-translation-keys-in-select-components branch October 24, 2025 20:31
@github-project-automation github-project-automation bot moved this from In Review to Done in Pokémon Studio Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants