Skip to content

Add a reset of the text index when switching to the previous or next text file using shortcuts#675

Merged
AerunDev merged 2 commits intodevelopfrom
659-reset-text-index-when-switching-to-previous-next-text-file-using-shortcuts
Oct 24, 2025
Merged

Add a reset of the text index when switching to the previous or next text file using shortcuts#675
AerunDev merged 2 commits intodevelopfrom
659-reset-text-index-when-switching-to-previous-next-text-file-using-shortcuts

Conversation

@GaburaisuVGC
Copy link
Collaborator

@GaburaisuVGC GaburaisuVGC commented Oct 19, 2025

Description

This code fixes the issue where the text index wasn't set to 1 when we switch text files, in the Translation Page.
My goal was to check where I could trigger a change when I change the selected text file, then check inside the trigger if the text file is changed, and only if it's the case, reset the index.

Closes #659

Tests to perform

  1. Open a project and go to the Text Manager page, in the Translation section.
  2. Change the index (for example: from 1 to 3)
  3. Then, change the text file: the index should be back to 1.
  4. You can try changing the target language just to be sure the index doesn't reset in that case.

@AerunDev AerunDev reopened this Oct 19, 2025
Copy link
Collaborator

@Aelysya Aelysya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça marche nickel, bien joué 😄

Concernant la PR elle-même j'ai deux conseils pour toi:

  • Tu peux lier une issue à ta PR pour qu'elle se ferme automatiquement dès que la PR est merge. Pour ça tu peux utiliser le mot clé closes et suivre par le numéro de l'issue (dans ton cas, ce sera closes #659)
  • Pense à t'auto-assigner tes PRs (c'est Palb qui m'a dit de faire ça y a pas longtemps) comme ça sur la liste des PRs on voit qui a fait quoi directement. tu peux le faire ici:
image

Copy link
Collaborator

@AntoinePoree AntoinePoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👌

@AerunDev AerunDev changed the title Added a text index reset when switching text files in the translation… Add a reset of the text index when switching to the previous or next text file using shortcuts Oct 24, 2025
@AerunDev AerunDev merged commit 792fe5a into develop Oct 24, 2025
5 checks passed
@AerunDev AerunDev deleted the 659-reset-text-index-when-switching-to-previous-next-text-file-using-shortcuts branch October 24, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset the text index when switching to the previous or next text file using shortcuts

5 participants