Conversation
Aelysya
approved these changes
Oct 19, 2025
Collaborator
Aelysya
left a comment
There was a problem hiding this comment.
Ça marche nickel, bien joué 😄
Concernant la PR elle-même j'ai deux conseils pour toi:
- Tu peux lier une issue à ta PR pour qu'elle se ferme automatiquement dès que la PR est merge. Pour ça tu peux utiliser le mot clé
closeset suivre par le numéro de l'issue (dans ton cas, ce seracloses #659) - Pense à t'auto-assigner tes PRs (c'est Palb qui m'a dit de faire ça y a pas longtemps) comme ça sur la liste des PRs on voit qui a fait quoi directement. tu peux le faire ici:
Palbolsky
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This code fixes the issue where the text index wasn't set to 1 when we switch text files, in the Translation Page.
My goal was to check where I could trigger a change when I change the selected text file, then check inside the trigger if the text file is changed, and only if it's the case, reset the index.
Closes #659
Tests to perform