Skip to content

Fix a text field in the Zones page that was allowing null values#676

Merged
AerunDev merged 1 commit intodevelopfrom
fix-zone-panel-id-field-that-can-be-null
Oct 24, 2025
Merged

Fix a text field in the Zones page that was allowing null values#676
AerunDev merged 1 commit intodevelopfrom
fix-zone-panel-id-field-that-can-be-null

Conversation

@Aelysya
Copy link
Collaborator

@Aelysya Aelysya commented Oct 19, 2025

Description

This PR fixes the text field for choosing the PanelId of a Zone that was not preventing the editor from closing if it had no value, resulting in a null value in the JSON file and causing the project to fail loading.

Link to the topix that highlighted this issue

Tests to perform

  • Open a zone's page and open the Settings editor, remove the value in the Panel number field and close the editor, the value 0 is automatically set to avoid a null

@Aelysya Aelysya self-assigned this Oct 19, 2025
Copy link
Collaborator

@AntoinePoree AntoinePoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu le Clean Value, j'ai lancé un projet avec une value du panel à 0, aucun soucis pour moi. 👌

@AerunDev AerunDev added the Bug Something isn't working label Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Review in Pokémon Studio Oct 24, 2025
@AerunDev AerunDev merged commit 33956ec into develop Oct 24, 2025
5 checks passed
@AerunDev AerunDev deleted the fix-zone-panel-id-field-that-can-be-null branch October 24, 2025 20:47
@github-project-automation github-project-automation bot moved this from In Review to Done in Pokémon Studio Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants