Conversation
Palbolsky
approved these changes
Nov 5, 2025
Collaborator
Palbolsky
left a comment
Palbolsky
left a comment
There was a problem hiding this comment.
Testé et le bug est bien corrigé.
J'ai simplement relevé une duplication de code, à voir si on peut créer facilement une fonction.
Palbolsky
approved these changes
Nov 8, 2025
AerunDev
approved these changes
Nov 9, 2025
AerunDev
changed the title
AerunDev
deleted the
680-creating-quests-by-importing-another-one-with-custom-goals-make-those-goals-using-the-same-text-entry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues that are closely related. When custom goals are created via an importation method (whether by creating an entire quest with existing data, or only importing another quest's goals) the text IDs used by these goals were the same as the imported ones, creating conflicts.
closes #680
Note before testing
Tests to perform