Skip to content

Copy default sprites to female sprites when setting a Creature to 100% female#708

Merged
AerunDev merged 2 commits intodevelopfrom
707-copy-default-resources-to-female-resources-when-setting-female-rate-to-100
Jan 18, 2026
Merged

Copy default sprites to female sprites when setting a Creature to 100% female#708
AerunDev merged 2 commits intodevelopfrom
707-copy-default-resources-to-female-resources-when-setting-female-rate-to-100

Conversation

@Aelysya
Copy link
Collaborator

@Aelysya Aelysya commented Jan 16, 2026

Description

This PR makes it that when setting a Creature to be 100% female, it's default sprite names are copied into it's female sprite names if they're not already set.
This is to avoid the situation where the user first sets the default sprites, then changes the creature to 100% female and has to re-set the sprites for the female version.

closes #707

Tests to perform

  • Change the female rate of a Creature to another value below 100, no changes should happen in the resources
  • Change the female rate of a Creature to 100, the female-related resources that were previously absent from the JSON, or had an empty value should be replaced by the male sprite value.

@Aelysya Aelysya self-assigned this Jan 16, 2026
Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works properly, gj!

Image

@AerunDev AerunDev merged commit 82adddf into develop Jan 18, 2026
5 checks passed
@AerunDev AerunDev deleted the 707-copy-default-resources-to-female-resources-when-setting-female-rate-to-100 branch January 18, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy default resources to female resources when setting female rate to 100%

3 participants