Skip to content

Fix missing checks for ivs and evs for the encounters#711

Merged
AerunDev merged 1 commit intodevelopfrom
fix-missing-check-for-evs-and-ivs-for-encounters
Jan 18, 2026
Merged

Fix missing checks for ivs and evs for the encounters#711
AerunDev merged 1 commit intodevelopfrom
fix-missing-check-for-evs-and-ivs-for-encounters

Conversation

@Palbolsky
Copy link
Collaborator

@Palbolsky Palbolsky commented Jan 18, 2026

Description

The issue has been reported here: https://discord.com/channels/143824995867557888/1462474485348175973

The check for the ivs and evs in the usePokemonBattler hook was not working due to an implementation error. This PR fixes the check.

Tests to perform

  • When they're adding a creature in a group, trainer or quest earning, the user cannot add the creature if the ivs or evs is empty or not between 0 and 9999.
  • When they're editing a creature in a group, trainer or quest earning, the user cannot close the editor if the creature has the iv or ev is not between 0 and 9999. Empty value is allowed.

@Palbolsky Palbolsky self-assigned this Jan 18, 2026
@Palbolsky Palbolsky added the Bug Something isn't working label Jan 18, 2026
@Palbolsky Palbolsky moved this from Backlog to In Review in Pokémon Studio Jan 18, 2026
@AerunDev AerunDev merged commit 5484771 into develop Jan 18, 2026
5 checks passed
@AerunDev AerunDev deleted the fix-missing-check-for-evs-and-ivs-for-encounters branch January 18, 2026 18:22
@github-project-automation github-project-automation bot moved this from In Review to Done in Pokémon Studio Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants