Skip to content

Remove the default Given Name of a creature in PokemonBattler logic#714

Merged
AerunDev merged 1 commit intodevelopfrom
710-remove-the-default-given-name-of-a-creature-in-pokemonbattler-logic
Feb 2, 2026
Merged

Remove the default Given Name of a creature in PokemonBattler logic#714
AerunDev merged 1 commit intodevelopfrom
710-remove-the-default-given-name-of-a-creature-in-pokemonbattler-logic

Conversation

@Karbbone
Copy link
Collaborator

Thank you for your contribution to the Pokémon Studio repo.

Before submitting this PR into the develop branch, please make sure:

  • Your code builds clean without any errors or warnings
  • You are following the Code guidelines
  • You tested your code to make sure it does what it is supposed to do

Description

Remove the default name given put it at all empty string by default if the input is empty.

Note before testing

Tests to perform

  1. Create the trainer
  2. Add a Pokémon to the trainer
  3. Change the game’s default language in Studio options
  4. Open and close the Pokémon editor to trigger the change
  5. Save

Petite PR rapide ça faisait longtemps.

@Karbbone Karbbone self-assigned this Jan 29, 2026
@Karbbone Karbbone linked an issue Jan 29, 2026 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testé, et c'est tout bon pour moi, merci ! 😄

@AerunDev AerunDev merged commit c11d851 into develop Feb 2, 2026
5 checks passed
@AerunDev AerunDev deleted the 710-remove-the-default-given-name-of-a-creature-in-pokemonbattler-logic branch February 2, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the default Given Name of a creature in PokemonBattler logic

4 participants