[codex] Add explicit PE SOI path override for rebuild CLI#155
Draft
anth-volk wants to merge 2 commits into
Draft
[codex] Add explicit PE SOI path override for rebuild CLI#155anth-volk wants to merge 2 commits into
anth-volk wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147
Summary
policyengine_us_data/storage/soi.csvunder--policyengine-us-data-repo.soi_pathplumbing through the default PE-US rebuild source-provider factory and checkpoint CLI (--soi-path).soi_pathto the PUF provider.Root Cause
The PUF PE-SOI uprating path expects
policyengine_us_data/storage/soi.csvwhen only--policyengine-us-data-repois provided. In the affected fresh-checkout run, that file was absent while the tracked calibration target file existed elsewhere. Rather than guessing alternate storage paths, callers can now supply the intended SOI file explicitly with--soi-path.SOI Route Check
microplex-usdefault repo route:<policyengine-us-data repo>/policyengine_us_data/storage/soi.csv.download_prerequisites.pydoes not listsoi.csv; it downloads PUF/demographic/NP and geography prerequisites, not this SOI artifact.policyengine_us_data/storage/soi.csvexists but is not tracked;policyengine_us_data/storage/calibration_targets/soi_targets.csvis tracked. Use--soi-pathfor that alternate file when needed.Validation
uv run --no-sync ruff check src/microplex_us/data_sources/puf.py src/microplex_us/pipelines/pe_us_data_rebuild.py src/microplex_us/pipelines/pe_us_data_rebuild_checkpoint.py tests/test_puf_source_provider.py tests/pipelines/test_pe_us_data_rebuild_checkpoint.pyuv run --no-sync python -m py_compile src/microplex_us/data_sources/puf.py src/microplex_us/pipelines/pe_us_data_rebuild.py src/microplex_us/pipelines/pe_us_data_rebuild_checkpoint.py tests/test_puf_source_provider.py tests/pipelines/test_pe_us_data_rebuild_checkpoint.pyNotes
mainstill has the no-torch core import issue addressed separately by [codex] Split PE rebuild CLI parsing from runtime imports #154; test-module import stalls in this no-torch environment before reaching the new PE-US rebuild smoke expects missingpolicyengine_us_data/storage/soi.csv#147 case.