Ignore empty gateway auth required setting#473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #472
Summary
Fix the deploy integration-test collection failure when
GATEWAY_AUTH_REQUIREDis not configured yet.GitHub Actions can pass an unset variable through as an empty string. After #471, that empty string reached
simulation_integ_test_gateway_auth_required, and Pydantic attempted to parse""as a boolean instead of using the field default.Changes
env_ignore_empty=Truefor the simulation integration settings so empty env values fall back to defaults.simulation_integ_test_gateway_auth_requiredfrommodal-run-integ-tests.shwhenGATEWAY_AUTH_REQUIREDis non-empty.Validation
bash -n .github/scripts/modal-run-integ-tests.shuv run ruff check projects/policyengine-apis-integ/tests/simulation/conftest.py./scripts/generate-clients.shsimulation_integ_test_gateway_auth_required=""loads asFalsesimulation_integ_test_gateway_auth_required=1loads asTrueuv run pytest tests/simulation/test_auth_smoke.py -qskips cleanly while auth is not required