Skip to content

Fix missing simulation job polling status#475

Merged
anth-volk merged 1 commit intomainfrom
fix/job-not-found-404
Apr 29, 2026
Merged

Fix missing simulation job polling status#475
anth-volk merged 1 commit intomainfrom
fix/job-not-found-404

Conversation

@anth-volk
Copy link
Copy Markdown
Contributor

Fixes #474

Summary

  • Treat job IDs absent from the gateway metadata store as 404s before asking Modal for a call result.
  • Map Modal job-not-found and expired-output errors to 404 for jobs that were previously issued by the gateway.
  • Preserve 202 for running jobs and redacted 500s for actual worker failures.
  • Add gateway unit coverage for unknown jobs, lazy Modal handles without metadata, running jobs, expired output, Modal not-found, and worker errors.

Testing

  • uv run pytest tests/gateway/test_endpoints.py tests/gateway/test_auth.py -q
  • uv run ruff check src/modal/gateway/endpoints.py tests/gateway/test_endpoints.py fixtures/gateway/test_endpoints.py
  • uv run ruff format --check src/modal/gateway/endpoints.py tests/gateway/test_endpoints.py fixtures/gateway/test_endpoints.py

@anth-volk anth-volk marked this pull request as ready for review April 29, 2026 20:17
@anth-volk anth-volk merged commit 614f233 into main Apr 29, 2026
4 checks passed
@anth-volk anth-volk deleted the fix/job-not-found-404 branch April 29, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return 404 for missing simulation gateway jobs

1 participant