Upgrade simulation API to PolicyEngine v4.10#502
Draft
anth-volk wants to merge 14 commits into
Draft
Conversation
Contributor
Author
|
Note for follow-up: this PR intentionally does not restore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #503
Summary
policyengine==4.10.0while keeping existing API response contracts intact.policyengine-us,policyengine-us-data,policyengine-uk, andpolicyengine-uk-dataversions from the bundled policyengine.py release manifests instead of independently pinned/hard-coded values.policyengineand syncs country package pins to the newly bundled versions in the same branch.policyengine_bundlemetadata from the same manifest-derived source, includingpolicyengine_version, country model version, data package version, and manifest dataset URI.src/modal/simulation_output_builder.py;SimulationOutputBuildercalls the PolicyEngine analysis/output functions, transforms raw.pyobjects into our segment schemas, and owns finalbuild()/serialize()output assembly.simulation_output_adapter.pylayer so the runtime builder is the single owner of.pycalling, transformation, and serialization.policyengine-us-data: canonicaldocs/engineering/skills/, thin tool-specific adapters, PR template, contributing guidance, and same-repository draft PR rules.Testing
uv run ruff check src/modal/simulation.py src/modal/simulation_macro_output.py src/modal/simulation_output_builder.py tests/test_simulation_output_builder.py fixtures/test_simulation_output_builder.pyuv run pytest tests/test_simulation_output_builder.py tests/test_simulation_api_contracts.py tests/test_release_bundle.py tests/test_policyengine_dependency_source.py tests/test_modal_scripts.py tests/test_policyengine_package_update_scripts.py tests/gateway/test_endpoints.py tests/gateway/test_models.py -qgit diff --checkgit diff --cached --checkmake -n push-pr-branchmake -n help