Install FastAPI in simulation worker image#536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535
Summary
fastapi>=0.115.0to the Modal simulation worker image so importingpolicyengine_api_simulation.*does not crash at container startup.run_simulationandrun_budget_window_batch, which were crash-looping on the same missing dependency.Failed deploy evidence
test_calculate_specific_model,test_budget_window_multi_year_batch_completespolicyengine-simulation-py4-12-0showedModuleNotFoundError: No module named 'fastapi'while importingpolicyengine_api_simulation.release_bundlethrough package__init__.Testing
uv run ruff format --check src/modal/app.pyuv run pytest tests/test_policyengine_dependency_source.py -quv run python -c "import src.modal.app; print(src.modal.app.APP_NAME)"