Summary
The ensure-model-version-aligns-with-sim-api GitHub Action job checks that the policyengine-us and policyengine-uk package versions used by API v1 are deployed in the Modal simulation API before allowing deployment to proceed.
However, the UK version check should be removed because policyengine-uk does not support the older Python versions that API v1 runs on. This means the UK version deployed to Modal may not match the version pinned in API v1's requirements, causing the version check to fail even when it shouldn't block deployment.
Changes Required
- Modify
.github/request-simulation-model-versions.sh to only check US versions
- Add a comment explaining why UK versions are not checked
- The script should still accept the
-uk flag for backwards compatibility but ignore it
Context
- API v1 runs on an older Python version
- policyengine-uk has dropped support for that Python version
- The Modal simulation API may have a newer UK version deployed that works with the newer Python version
- US package (policyengine-us) still supports the older Python version, so that check remains valid
Summary
The
ensure-model-version-aligns-with-sim-apiGitHub Action job checks that the policyengine-us and policyengine-uk package versions used by API v1 are deployed in the Modal simulation API before allowing deployment to proceed.However, the UK version check should be removed because policyengine-uk does not support the older Python versions that API v1 runs on. This means the UK version deployed to Modal may not match the version pinned in API v1's requirements, causing the version check to fail even when it shouldn't block deployment.
Changes Required
.github/request-simulation-model-versions.shto only check US versions-ukflag for backwards compatibility but ignore itContext