Skip to content

Move App Engine deploy tests out of the Docker build #3523

@anth-volk

Description

@anth-volk

The App Engine deploy image currently runs make test during docker build, which mixes release testing with artifact construction and makes the build sensitive to local bootstrap side effects such as .env generation and placeholder ADC paths.

This causes two concrete problems:

  • push-time tests rely on Docker build-time credentials instead of the runner's authenticated environment
  • the build can fail for reasons unrelated to the runtime image, such as fake GOOGLE_APPLICATION_CREDENTIALS from .env.example

The deploy path should instead:

  • run push-time API tests on the GitHub runner before deploy
  • keep those checks ordered within the staging deploy flow
  • build the App Engine image separately from the test harness
  • leave local .env setup as an explicit developer step rather than an install side effect

This keeps staging gating intact while making the App Engine image build closer to a pure packaging step.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions