Move to Simulation API#2262
Conversation
…-api into nikhilwoodruff/issue2251
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2262 +/- ##
==========================================
- Coverage 77.16% 75.51% -1.66%
==========================================
Files 88 88
Lines 3377 3476 +99
Branches 366 393 +27
==========================================
+ Hits 2606 2625 +19
- Misses 703 781 +78
- Partials 68 70 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anth-volk
left a comment
There was a problem hiding this comment.
Good to catch errors. LGTM!
I mistakenly thought the PR was just the final commit
There was a problem hiding this comment.
Thanks for this @nikhilwoodruff, curious to hear your thoughts. This was a lot of fun to review, and I'm very excited to incorporate this.
There was a problem hiding this comment.
Thanks for these updates @nikhilwoodruff, loving the progress on this. Just had a few more questions for you. I also unresolved a couple points just to ask a couple follow-up questions.
anth-volk
left a comment
There was a problem hiding this comment.
Thanks for these changes, @nikhilwoodruff. Happy to approve, pending any token-related issues Mike had highlighted.
Fixes #2251
To-do: run using cloud workflows, not localhost.