Skip to content

Move to Simulation API#2262

Merged
nikhilwoodruff merged 35 commits into
masterfrom
nikhilwoodruff/issue2251
Apr 8, 2025
Merged

Move to Simulation API#2262
nikhilwoodruff merged 35 commits into
masterfrom
nikhilwoodruff/issue2251

Conversation

@nikhilwoodruff
Copy link
Copy Markdown
Collaborator

@nikhilwoodruff nikhilwoodruff commented Mar 14, 2025

Fixes #2251

To-do: run using cloud workflows, not localhost.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 19.19192% with 80 lines in your changes missing coverage. Please review.

Project coverage is 75.51%. Comparing base (61c0885) to head (d60c049).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ngine_api/jobs/calculate_economy_simulation_job.py 19.19% 78 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
- Coverage   77.16%   75.51%   -1.66%     
==========================================
  Files          88       88              
  Lines        3377     3476      +99     
  Branches      366      393      +27     
==========================================
+ Hits         2606     2625      +19     
- Misses        703      781      +78     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikhilwoodruff nikhilwoodruff marked this pull request as ready for review March 28, 2025 11:36
@nikhilwoodruff nikhilwoodruff requested a review from mikesmit March 28, 2025 11:51
@nikhilwoodruff nikhilwoodruff requested a review from anth-volk April 1, 2025 16:23
anth-volk
anth-volk previously approved these changes Apr 1, 2025
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to catch errors. LGTM!

@anth-volk anth-volk dismissed their stale review April 1, 2025 18:18

I mistakenly thought the PR was just the final commit

@anth-volk anth-volk self-requested a review April 1, 2025 18:19
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @nikhilwoodruff, curious to hear your thoughts. This was a lot of fun to review, and I'm very excited to incorporate this.

Comment thread CHANGELOG.md
Comment thread changelog.yaml
Comment thread policyengine_api/constants.py Outdated
Comment thread policyengine_api/endpoints/economy/compare.py
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py
Comment thread .github/workflows/pr.yml Outdated
Comment thread .github/workflows/push.yml Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @nikhilwoodruff, loving the progress on this. Just had a few more questions for you. I also unresolved a couple points just to ask a couple follow-up questions.

Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py Outdated
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, @nikhilwoodruff. Happy to approve, pending any token-related issues Mike had highlighted.

Comment thread policyengine_api/jobs/calculate_economy_simulation_job.py
@nikhilwoodruff nikhilwoodruff merged commit 2c50fc0 into master Apr 8, 2025
5 of 7 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue2251 branch April 8, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to Simulation API

3 participants