Skip to content

Conversation

@nikhilwoodruff
Copy link
Collaborator

Fixes #2322
Fixes #2321

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk April 2, 2025 11:19
@nikhilwoodruff nikhilwoodruff self-assigned this Apr 2, 2025
@nikhilwoodruff nikhilwoodruff added the enhancement New feature or request label Apr 2, 2025
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.45%. Comparing base (cfa6976) to head (f7c07e9).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...ngine_api/jobs/calculate_economy_simulation_job.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2323      +/-   ##
==========================================
- Coverage   63.55%   63.45%   -0.11%     
==========================================
  Files          55       55              
  Lines        2154     2159       +5     
  Branches      286      286              
==========================================
+ Hits         1369     1370       +1     
- Misses        727      731       +4     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk April 4, 2025 09:43
Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in review @nikhilwoodruff. This looks good to me, but I'll let you merge (or modify) in case there's been any change in need here, given some other subsampling-related changes we've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable US subsampling with new Core fixes Ensure US model always downloads datasets from HuggingFace

3 participants