Fix tracer parsing function to properly handle variables #2330
Conversation
…are substrings of other variables
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
+ Coverage 77.16% 77.20% +0.04%
==========================================
Files 88 88
Lines 3377 3383 +6
Branches 366 366
==========================================
+ Hits 2606 2612 +6
Misses 703 703
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
Hi @SonaliBedge,
Thanks for your contributions on this issue. I have a minor edit, but otherwise, I think this is good to merge! Thank you very much.
changelog_entry.yaml
Outdated
| - bump: patch | ||
| changes: | ||
| changed: | ||
| - Fixed tracer parsing function. It was not properly handle variable whose names are substrings of other variables. |
There was a problem hiding this comment.
nit: Typo
| - Fixed tracer parsing function. It was not properly handle variable whose names are substrings of other variables. | |
| - Fixed tracer parsing function. It was not properly handling variables whose names are substrings of other variables. |
Thank you! I appreciate the feedback. I made changes. Glad to hear it's ready to merge! |
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
Thanks for your work on this @SonaliBedge! This looks great. It'll be great having a fix to this issue.
| assert result == expected_output | ||
|
|
||
|
|
||
| def test_tracer_output_for_variable_that_is_substring_of_another(): |
There was a problem hiding this comment.
accolade: I really appreciate how quickly you were able to get oriented on our code base. Great to have a test for this issue!
fixes #2304
Fix tracer parsing function to properly handle variables whose names are substrings of other variables