Skip to content

Fix APIv2 comparison to allow zero = 1e-5#2361

Merged
nikhilwoodruff merged 1 commit into
masterfrom
adjust-comp-fn
Apr 11, 2025
Merged

Fix APIv2 comparison to allow zero = 1e-5#2361
nikhilwoodruff merged 1 commit into
masterfrom
adjust-comp-fn

Conversation

@nikhilwoodruff
Copy link
Copy Markdown
Collaborator

@nikhilwoodruff nikhilwoodruff commented Apr 10, 2025

Fixes #2362

@nikhilwoodruff nikhilwoodruff changed the title Fix APIv2 comparison Fix APIv2 comparison to allow zero = 1e-5 Apr 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.49%. Comparing base (58241ba) to head (99d998c).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...ngine_api/jobs/calculate_economy_simulation_job.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
- Coverage   77.16%   75.49%   -1.68%     
==========================================
  Files          88       88              
  Lines        3377     3477     +100     
  Branches      366      394      +28     
==========================================
+ Hits         2606     2625      +19     
- Misses        703      782      +79     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikhilwoodruff nikhilwoodruff merged commit d7b398b into master Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APIv2 comparisons don't correctly compare zero values

1 participant