Added test for update_profile method #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
- Coverage 77.16% 76.40% -0.77%
==========================================
Files 88 92 +4
Lines 3377 3607 +230
Branches 366 404 +38
==========================================
+ Hits 2606 2756 +150
- Misses 703 783 +80
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anth-volk
approved these changes
Apr 19, 2025
Collaborator
There was a problem hiding this comment.
@irisbian504 This looks great! I have a couple nits highlighted. Otherwise, could you create an issue to add tests for the update_profile method, then add "Fixes #XXXX" in the PR description?
|
|
||
| # WHEN we call update_profile with new data | ||
| updated_username = "updated_username" | ||
| updated_country = "UK" |
Collaborator
There was a problem hiding this comment.
nit: Technically, this should be lowercase
| # WHEN we call update_profile for this nonexistent record | ||
| result = service.update_profile( | ||
| user_id=NONEXISTENT_ID, | ||
| primary_country="UK", |
Collaborator
There was a problem hiding this comment.
nit: Here, too, this would be lowercase in production
anth-volk
approved these changes
May 17, 2025
Collaborator
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
LGTM! Thanks @irisbian504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2393