Skip to content

Conversation

@Swetna
Copy link
Collaborator

@Swetna Swetna commented Apr 10, 2025

Fixes #2364.
Fixes #2365.

@Swetna Swetna requested a review from anth-volk April 10, 2025 21:27
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.70%. Comparing base (58241ba) to head (7f7e843).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2367      +/-   ##
==========================================
- Coverage   77.16%   75.70%   -1.47%     
==========================================
  Files          88       90       +2     
  Lines        3377     3515     +138     
  Branches      366      397      +31     
==========================================
+ Hits         2606     2661      +55     
- Misses        703      784      +81     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
Copy link
Collaborator

Please do the following:

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Swetna! Once the changes to the PR title and description are made, we can merge.

@Swetna Swetna changed the title Patch issue 2364 and 2365 Renaming TestGetTrace (#2364 ) and Move household fixtures file to correct folder(#2365) Apr 16, 2025
@anth-volk anth-volk changed the title Renaming TestGetTrace (#2364 ) and Move household fixtures file to correct folder(#2365) Renaming TestGetTrace and move household fixtures file to correct folder Apr 19, 2025
@anth-volk
Copy link
Collaborator

@Swetna Thanks for this. I've gone ahead and made modifications to create an exemplar - this is what we're looking for in the future when naming PRs and adding to the description. As such, we can now merge.

@anth-volk anth-volk self-requested a review April 19, 2025 00:53
@anth-volk anth-volk merged commit 2e041c1 into master Apr 19, 2025
6 of 7 checks passed
@anth-volk anth-volk deleted the patch-issue-2364/2365 branch April 19, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move household fixtures file to correct folder Rename TestGetTrace

4 participants