Add test for Utah state tax reform#2418
Merged
Merged
Conversation
Collaborator
|
Appears this failed tests previously due to a permissions error. Attempted to fix in GCP. |
Collaborator
|
Appears I assigned the wrong role in IAM. Trying again. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
+ Coverage 62.18% 63.75% +1.57%
==========================================
Files 54 54
Lines 2081 2028 -53
Branches 276 253 -23
==========================================
- Hits 1294 1293 -1
+ Misses 738 686 -52
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@anth-volk it's now passing the test- I ran the policyengine.py package locally on the latest versions of the data and pe-us package and it also returned 95.1m, so I think that's the true number we're aiming for. I also added a test for the winner/loser share. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2417