Skip to content

Add test for Utah state tax reform#2418

Merged
nikhilwoodruff merged 9 commits into
masterfrom
nikhilwoodruff/issue2417
May 1, 2025
Merged

Add test for Utah state tax reform#2418
nikhilwoodruff merged 9 commits into
masterfrom
nikhilwoodruff/issue2417

Conversation

@nikhilwoodruff
Copy link
Copy Markdown
Collaborator

Fixes #2417

@anth-volk
Copy link
Copy Markdown
Collaborator

Appears this failed tests previously due to a permissions error. Attempted to fix in GCP.

@anth-volk
Copy link
Copy Markdown
Collaborator

Appears I assigned the wrong role in IAM. Trying again.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (2587223) to head (85b8c38).
Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
...ngine_api/jobs/calculate_economy_simulation_job.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
+ Coverage   62.18%   63.75%   +1.57%     
==========================================
  Files          54       54              
  Lines        2081     2028      -53     
  Branches      276      253      -23     
==========================================
- Hits         1294     1293       -1     
+ Misses        738      686      -52     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikhilwoodruff
Copy link
Copy Markdown
Collaborator Author

@anth-volk it's now passing the test- I ran the policyengine.py package locally on the latest versions of the data and pe-us package and it also returned 95.1m, so I think that's the true number we're aiming for. I also added a test for the winner/loser share.

@nikhilwoodruff nikhilwoodruff merged commit 1105419 into master May 1, 2025
6 of 7 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue2417 branch May 1, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for Utah state tax reform

2 participants