Skip to content

Migrate to APIv2#2558

Merged
nikhilwoodruff merged 7 commits into
masterfrom
nikhilwoodruff/issue2557
Jun 10, 2025
Merged

Migrate to APIv2#2558
nikhilwoodruff merged 7 commits into
masterfrom
nikhilwoodruff/issue2557

Conversation

@nikhilwoodruff
Copy link
Copy Markdown
Collaborator

@nikhilwoodruff nikhilwoodruff commented Jun 8, 2025

Fixes #2557
Requires merging of #2547.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 13.51351% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.98%. Comparing base (d79b3f2) to head (ddc70ae).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ngine_api/jobs/calculate_economy_simulation_job.py 11.11% 31 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
+ Coverage   63.55%   63.98%   +0.42%     
==========================================
  Files          56       55       -1     
  Lines        2220     2113     -107     
  Branches      296      264      -32     
==========================================
- Hits         1411     1352      -59     
+ Misses        747      708      -39     
+ Partials       62       53       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@mikesmit mikesmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking comment otherwise lgtm

Comment thread changelog_entry.yaml

if not check_against_api_v2:
if not run_api_v2:
logger.log_text(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking This is an error, not a warn and shouldn't we fail in some way the API will expose to the user? (i.e. if we aren't running api_v2 then we aren't running a simulation at all any more right)

@anth-volk anth-volk force-pushed the nikhilwoodruff/issue2557 branch from b1afaf3 to 96b084f Compare June 9, 2025 21:59
@anth-volk
Copy link
Copy Markdown
Collaborator

Tests fail due to API v2 model version being lower than v1. Attempted to deploy newer version of v2, but deployment fails tests here.

@anth-volk anth-volk force-pushed the nikhilwoodruff/issue2557 branch from c2061d1 to 44d9875 Compare June 9, 2025 23:47
@nikhilwoodruff
Copy link
Copy Markdown
Collaborator Author

This looks OK to me, and I see the latest APIv2 update deployed correctly.

@nikhilwoodruff nikhilwoodruff merged commit c06b2e6 into master Jun 10, 2025
6 of 7 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue2557 branch June 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to APIv2

3 participants