Migrate to APIv2#2558
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2558 +/- ##
==========================================
+ Coverage 63.55% 63.98% +0.42%
==========================================
Files 56 55 -1
Lines 2220 2113 -107
Branches 296 264 -32
==========================================
- Hits 1411 1352 -59
+ Misses 747 708 -39
+ Partials 62 53 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikesmit
left a comment
There was a problem hiding this comment.
One blocking comment otherwise lgtm
|
|
||
| if not check_against_api_v2: | ||
| if not run_api_v2: | ||
| logger.log_text( |
There was a problem hiding this comment.
blocking This is an error, not a warn and shouldn't we fail in some way the API will expose to the user? (i.e. if we aren't running api_v2 then we aren't running a simulation at all any more right)
b1afaf3 to
96b084f
Compare
|
Tests fail due to API v2 model version being lower than v1. Attempted to deploy newer version of v2, but deployment fails tests here. |
c2061d1 to
44d9875
Compare
|
This looks OK to me, and I see the latest APIv2 update deployed correctly. |
Fixes #2557
Requires merging of #2547.