Extract pathway wrappers to Next.js routes#870
Open
SakshiKekre wants to merge 1 commit intonextjs-calculator-migrationfrom
Open
Extract pathway wrappers to Next.js routes#870SakshiKekre wants to merge 1 commit intonextjs-calculator-migrationfrom
SakshiKekre wants to merge 1 commit intonextjs-calculator-migrationfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
Collaborator
Review findings — PR #870 (Extract pathway wrappers)Code reviewer found no issues at confidence >= 80 — clean PR overall. HIGH
MEDIUM
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useNavigate→useAppNavigatein SimulationPathwayWrapper, PopulationPathwayWrapper, PolicyPathwayWrapper[countryId]/simulations/create,[countryId]/households/create,[countryId]/policies/createCalculatorProvidersRoute mapping
/:countryId/simulations/createcalculator-app/src/app/[countryId]/simulations/create/page.tsx/:countryId/households/createcalculator-app/src/app/[countryId]/households/create/page.tsx/:countryId/policies/createcalculator-app/src/app/[countryId]/policies/create/page.tsxTest plan
cd calculator-app && bun run dev— navigate to/us/simulations/create,/us/households/create,/us/policies/createbun run buildin calculator-app — no errorsbun run lintin app — no errors