Revert sorting code#2349
Merged
nikhilwoodruff merged 1 commit intoPolicyEngine:masterfrom Feb 7, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nikhilwoodruff
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2348
Reopens #2342
Changes
This code reverts the sorting code introduced as a fix to #2342. Unfortunately, this code made parameters (as opposed to parameter nodes) unclickable in the application.
In my opinion, part of the problem with the prior fix is that it assumed an implementation within
MenuandStackedMenu(two components used to generate the parameter list) that was not present.StackedMenuandMenucontain display logic that is, in my opinion, too tightly intertwined with the metadata structure itself, such that even merely sorting the metadata alphabetically causes bugs. An ideal implementation here would probably make both components more stylistic only, implementing a separate metadata parsing logic to enable easier modification where necessary.Screenshots
N/A
Tests
N/A