Fixed issue 1936: brackets sorting#2719
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anth-volk
approved these changes
Aug 13, 2025
Collaborator
anth-volk
left a comment
There was a problem hiding this comment.
Thanks for these contributions @AnushkaNilangekar! They're a real improvement to the UI. Generally, we'd ask for tests to accompany these, but given that we will be looking to deprecate this module by the end of the year, as well as the narrow scope of the changes, we will skip that this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1936
Description
This PR fixes the incorrect ordering of bracketed parameter nodes (e.g., "Bracket 10" appearing before "Bracket 2") in the parameter tree sidebar. The issue was caused by missing index assignments for bracket nodes in the parameter tree construction, and by sorting logic that did not distinguish between bracket and non-bracket nodes. This change ensures bracket nodes are always sorted numerically, while all other nodes are sorted alphabetically.
Changes
Parameter Tree Construction (parameters.js)
Assigns a numeric index to bracket nodes during tree construction, based on their bracket number.
Non-bracket nodes retain their default or module-based index.
Tree Sorting Logic (PolicyPage.jsx):
Updates the sortTreeInPlace function to:
Detect if all nodes at a given tree level are bracket nodes (using a regex on the label).
Sort bracket nodes numerically by their index property.
Sort all other nodes alphabetically by their label.
Screenshots
https://www.loom.com/share/cec71fa84dae43e6b58b7e08b49782d1?sid=3d6c2f5a-b909-4bdf-9dbd-790bf173b26d
Tests
Manually verified in the UI that bracketed parameters are now always sorted numerically, even for double-digit brackets. Confirmed that non-bracket nodes remain sorted alphabetically.