Fix review-fix loop skipping and narrow reference search#110
Merged
hua7450 merged 1 commit intoPolicyEngine:mainfrom Mar 6, 2026
Merged
Fix review-fix loop skipping and narrow reference search#110hua7450 merged 1 commit intoPolicyEngine:mainfrom
hua7450 merged 1 commit intoPolicyEngine:mainfrom
Conversation
Phase 6: Replace conditional while-loop with 3 explicitly named rounds (6.1, 6.2, 6.3). The orchestrator can no longer skip re-reviews after fixes — each round is a mandatory named step, not a loop iteration. Consolidator: Search for reference implementations by concept keywords (e.g., 'child', 'care') instead of program acronym. This prevents missing better references like TX CCS and DC CCSP when implementing a CCAP program. Parameter-architect: Remove hardcoded DC/IL/TX TANF paths. The agent now reads reference implementations from the consolidator's impl-spec. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues discovered during RI CCAP implementation:
Review-fix loop skipping — Phase 6 used a conditional
whileloop, giving the orchestrator discretion to skip re-reviews after fixes. The agent exited early by assuming its fixes resolved criticals instead of re-running/review-programto verify. Replaced with 3 explicitly named rounds (6.1, 6.2, 6.3) where each re-review is a mandatory step the orchestrator cannot skip.Narrow reference search — The consolidator searched for reference implementations by program acronym (e.g.,
ccap), missing better references like TX CCS and DC CCSP that use different names for the same program type. Now searches by concept keywords derived from what the program does (e.g.,child,care,provider).Hardcoded TANF references — The parameter-architect had hardcoded DC/IL/TX TANF paths. Now reads reference implementations from the consolidator's impl-spec instead.
Changes
commands/encode-policy-v2.md— Phase 6 restructured, consolidator STEP 1 rewrittenagents/country-models/parameter-architect.md— Hardcoded paths removed, reads from impl-spec🤖 Generated with Claude Code