chore: drop stale API/workflow/dataset blocks from system prompt#37
Closed
vahid-ahmadi wants to merge 1 commit intomainfrom
Closed
chore: drop stale API/workflow/dataset blocks from system prompt#37vahid-ahmadi wants to merge 1 commit intomainfrom
vahid-ahmadi wants to merge 1 commit intomainfrom
Conversation
Those sections were hardcoded examples that drift every time policyengine-uk-compiled ships a release. The cached reference added in #36 — docstrings, capabilities() snapshot, full Parameters JSON schema — is already the authoritative source, and the agent reaches the same answers by calling capabilities() dynamically. Keep only the behavioral guardrails and point the model at the reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Beta preview has been cleaned up because this PR was closed. |
Contributor
Author
|
Folded into #36 — keeping everything in a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMON WORKFLOWS,MODELLING SCOPE, andDATASETSsections fromSYSTEM_PROMPT.API AND DATASETSparagraph pointing the agent at the live reference doc introduced in feat: ground chat agent in a cached, auto-generated PolicyEngine API reference #36 (docstrings,capabilities()snapshot, fullParametersJSON schema).Why
The deleted blocks were hardcoded examples (
Simulation(year=2025, dataset="frs"),Parameters.model_validate({"income_tax": {"personal_allowance": 15000}}), per-dataset descriptions). They drift every timepolicyengine-uk-compiledships a release. With the cached reference from #36 in place, they duplicate the authoritative source — and without it, the agent already fetches the same content viacapabilities().Pairs well with #36: together, the unchanging behavioral rules stay in
SYSTEM_PROMPTand the version-sensitive facts live in the auto-generated reference.Test plan
docker-compose up→ ask "What datasets are available?" → response should list FRS, EFRS, LCFS, SPI, WAS (fromcapabilities()or the cached reference, not from the deleted prompt block)Parameters.model_validate({...})correctly without the hardcoded example🤖 Generated with Claude Code