Add version information to data locations#105
Merged
nikhilwoodruff merged 9 commits intomainfrom May 26, 2025
Merged
Conversation
nikhilwoodruff
commented
May 23, 2025
Contributor
Author
nikhilwoodruff
left a comment
There was a problem hiding this comment.
- Get version number as in this PR
- Tag HF uploads with that version number
- Set gcloud metadata with that version number
Contributor
Author
|
@mikesmit and @anth-volk, this is ready for re-review when you have a second. I've changed the data upload to:
|
nikhilwoodruff
commented
May 26, 2025
nikhilwoodruff
commented
May 26, 2025
nikhilwoodruff
commented
May 26, 2025
Contributor
Author
|
|
Contributor
Author
|
@anth-volk this PR now has the changes from our in-person review just now. |
anth-volk
requested changes
May 26, 2025
anth-volk
left a comment
There was a problem hiding this comment.
Was great to go through this @nikhilwoodruff. Probably 70% of the comments boil down to: you probably want to use GH Actions's needs keyword instead of depending on changes to particular files to avoid strange edge case bugs when sequencing push actions.
This was referenced May 26, 2025
anth-volk
requested changes
May 26, 2025
anth-volk
left a comment
There was a problem hiding this comment.
One question before approval, in the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104