[codex] Refresh HBAI columns after structural post-hooks#38
Merged
nikhilwoodruff merged 1 commit intomainfrom Apr 15, 2026
Merged
[codex] Refresh HBAI columns after structural post-hooks#38nikhilwoodruff merged 1 commit intomainfrom
nikhilwoodruff merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This refreshes derived household HBAI columns inside the Python
aggregate_microdata()path before poverty metrics are calculated. In particular, it recomputes*_net_income_ahc,*_equivalised_net_income, and*_equivalised_net_income_ahcfrom household net income, housing costs, and equivalisation factors.Why
Structural post-hooks can mutate household net income directly. Before this change, the Python aggregation layer trusted the pre-hook-derived HBAI columns already present on the household dataframe, so post-hooks could leave AHC and equivalised values stale. That made poverty outputs unreliable for household-level cash-transfer style reforms.
Impact
Household-level structural post-hooks now produce poverty results that stay consistent with the modified net incomes, without requiring each hook to manually update every derived HBAI field.
Validation
python -m compileall interfaces/python/policyengine_uk_compiled/structural.pyreform_net_income, then confirmed the patched aggregation produced sensible BHC and AHC poverty movement.