Document Ubuntu vs macOS reproducibility diagnosis (#1209)#1730
Open
vahid-ahmadi wants to merge 1 commit into
Open
Document Ubuntu vs macOS reproducibility diagnosis (#1209)#1730vahid-ahmadi wants to merge 1 commit into
vahid-ahmadi wants to merge 1 commit into
Conversation
#1209 reported PolicyEngine UK producing slightly different aggregates on ubuntu-latest vs macos-latest CI. The triage narrowed it to dict-iteration-order differences in apply_uprating's tree walk (closed fix attempt PR #1223). A series of follow-on PRs since rebuilt the affected uprating code path: - #1254 added multi-year datasets and separated uprating into a discrete pipeline step; - PRs #1543 / #1544 / commit 13a4ac7 rebuilt uprate_rent which was the primary visible site of divergence; - #1523 skipped a redundant dataset copy in apply_uprating. CI runs on ubuntu-latest only, so there's no live cross-OS test to prove the issue is fully resolved. Persist the diagnosis as a known- issue page so that, if reproducibility regression resurfaces, the next person doesn't have to re-derive the root-cause shape. Includes a sketched minimal regression test for reintroducing deterministic ordering once a cross-OS CI matrix is restored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestvsmacos-latestCI for the same dataset and version. The triage narrowed it to dict-iteration-order differences inapply_uprating's tree walk — only a limited subset of parameters were affected, but reproducibility-breaking.uprate_rent, the primary visible site of divergence.apply_uprating.ubuntu-latestnow, so we don't have a live cross-OS regression test. Persist the diagnosis atdocs/book/validation/ubuntu-vs-macos.mdso that, if cross-OS reproducibility regression resurfaces, the next person doesn't have to re-derive the root-cause shape.Test plan
validation/.🤖 Generated with Claude Code