Skip to content

Add typed Stage 5 promotion results#1027

Merged
anth-volk merged 1 commit into
mainfrom
agent/stage-5/pr-5-3-typed-promotion-results
May 22, 2026
Merged

Add typed Stage 5 promotion results#1027
anth-volk merged 1 commit into
mainfrom
agent/stage-5/pr-5-3-typed-promotion-results

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

Fixes #1026

Summary

  • Add typed Stage 5 promotion result dataclasses for HF, GCS, release manifest, version manifest, completion marker, cleanup, and full promotion outcomes.
  • Add a compatibility wrapper that calls the existing transaction engine first, then converts the returned dictionary into FullPromotionResult.
  • Preserve and extend transaction coverage for fresh promotion, already-finalized promotion, cleanup failure, skipped cleanup, and failure-before-write behavior.

Tests

  • ruff check policyengine_us_data/release_promotion policyengine_us_data/utils/release_promotion.py tests/unit/release_promotion
  • uv run --no-sync pytest tests/unit/release_promotion/test_results.py
  • uv run --no-sync --with huggingface-hub --with google-cloud-storage --with google-auth --with httpx --with tenacity --with pytest --with pytest-dependency python -m pytest tests/unit/utils/test_data_upload.py tests/unit/release_promotion
  • uv run --no-sync pytest tests/unit/test_stage_contracts.py tests/unit/release_promotion
  • uv run --no-sync --with pyyaml python scripts/run_quality_guards.py
  • uv run --no-sync --with pyyaml --with pytest pytest tests/unit/test_pipeline_docs_extractor.py tests/unit/test_pipeline_doc_guards.py
  • uv run --no-sync --with pyyaml python scripts/extract_pipeline_docs.py --json /private/tmp/usdata-pipeline-docs-pr53/pipeline_map.json --api-json /private/tmp/usdata-pipeline-docs-pr53/pipeline_api.json --markdown /private/tmp/usdata-pipeline-docs-pr53/pipeline-map.md
  • make lint

@anth-volk anth-volk force-pushed the agent/stage-5/pr-5-2-release-candidate-validation branch 2 times, most recently from b799f89 to 31f98e0 Compare May 21, 2026 19:18
Base automatically changed from agent/stage-5/pr-5-2-release-candidate-validation to main May 21, 2026 19:53
@anth-volk anth-volk force-pushed the agent/stage-5/pr-5-3-typed-promotion-results branch 5 times, most recently from cc3d369 to 3c424fe Compare May 21, 2026 21:26
@anth-volk anth-volk marked this pull request as ready for review May 22, 2026 12:41
@anth-volk anth-volk force-pushed the agent/stage-5/pr-5-3-typed-promotion-results branch from 3c424fe to 77458c0 Compare May 22, 2026 12:47
@anth-volk anth-volk merged commit f3f5077 into main May 22, 2026
13 checks passed
@anth-volk anth-volk deleted the agent/stage-5/pr-5-3-typed-promotion-results branch May 22, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add typed Stage 5 promotion results

1 participant