Skip to content

Route IA CDCC fraction lookup through consolidated taxable income#8566

Open
PavelMakarchuk wants to merge 1 commit into
mainfrom
add-obbba-schedule-1a-deductions-to-ia-taxable-income
Open

Route IA CDCC fraction lookup through consolidated taxable income#8566
PavelMakarchuk wants to merge 1 commit into
mainfrom
add-obbba-schedule-1a-deductions-to-ia-taxable-income

Conversation

@PavelMakarchuk
Copy link
Copy Markdown
Collaborator

Summary

Closes #8563.

The Iowa child/dependent care credit fraction lookup compares "taxable income" against bracket thresholds (75 % below $10K, 65 % to $20K, etc.). PE-US's ia_cdcc was reading the dynamically generated ia_taxable_income, which resolves to the legacy ia_taxable_income_joint / _indiv path that starts from ia_net_income (Iowa AGI minus IA deductions). The 2022 IA tax reform (HF 2317) shifted Iowa's tax base to federal taxable income for 2023+, so the credit should compare against ia_taxable_income_consolidated instead.

This also fixes the failure surfaced in PolicyEngine/policyengine-taxsim#953. Federal taxable income for the sample HoH-age-75 household is $7,166 (correctly netting the OBBBA $6K enhanced senior deduction), which lands in the < $10K 75 % bracket. The legacy path was returning $13,166 (missing the senior deduction), landing in the $10K–$20K 65 % bracket, so ia_cdcc was $448.50 instead of TaxAct's $517.50.

Add a formula_2023 branch that switches the comparand for 2023+. Pre-2023 behavior is preserved by leaving the original formula intact (it continues to read the legacy ia_taxable_income).

Test plan

  • New integration test from the issue (HoH age 75, $25K wages, $13.8K interest, 1 dep, $3.5K childcare, 2025, IA): ia_taxable_income_consolidated: 7_166, ia_cdcc: 517.5. Numerically matches TaxAct within $1.
  • New 2023 paired test: $1K cdcc_potential + $9,999.99 consolidated taxable income → $750 (75 % bracket).
  • Existing 2021/2022 unit tests unchanged.
  • Full IA suite (241 tests) passes.
  • `make format` clean.
  • CI green.

🤖 Generated with Claude Code

The Iowa child/dependent care credit fraction lookup compares
taxable income against bracket thresholds. PE-US's ia_cdcc was
reading the dynamically generated ia_taxable_income, which resolves
to the legacy ia_taxable_income_joint / _indiv path that starts
from ia_net_income (Iowa AGI minus IA deductions). For post-2023
years the 2022 IA tax reform (HF 2317) shifted Iowa's base to
federal taxable income, so the credit should compare against
ia_taxable_income_consolidated instead.

This also fixes the issue's failure: federal taxable income for the
sample HoH-age-75 household is $7,166 (correctly netting the OBBBA
$6K enhanced senior deduction), which lands in the < $10K 75%
bracket. The legacy path was returning $13,166 (missing the senior
deduction), landing in the 65% bracket, so ia_cdcc was $448.50
instead of $517.50.

Add a formula_2023 branch that switches the comparand for 2023+.
Pre-2023 behavior is preserved.

Closes #8563.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fa285ae) to head (a81f15a).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8566   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         1    -4     
  Lines           62        19   -43     
=========================================
- Hits            62        19   -43     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review June 2, 2026 14:35
@PavelMakarchuk PavelMakarchuk requested a review from hua7450 June 2, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IA taxable income missing federal Schedule 1-A senior deduction ($6,000 OBBBA) — Iowa Code § 422.7 conforms to federal taxable income

1 participant