Fix UK dataset issue#175
Merged
Merged
Conversation
Moved to the FRS 2023-24 dataset to resolve compatibility issues. Fixes #176
nikhilwoodruff
force-pushed
the
uk-dataset-issue-fix
branch
from
b93fb67 to
a676f16
Compare
Collaborator
Author
|
Had to remove the single household calculation page because of this issue. policyengine.py's household features are not used in production so not a blocker. |
Contributor
|
@nikhilwoodruff Just curious what this means: The new UK dataset format doesn't have the file path saved so we can't test it (but this is fine) Otherwise, thanks for flagging these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
Going to merge on tests pass but flagging for awareness @anth-volk
I had to adjust the tests:
called_withfunctionality seems to be dropped in 3.13Web app currently broken and these tests didn't catch a far more important failure so not going to block on improving them here.