feat: Expose parameter_nodes property on TaxBenefitModelVersion#254
Open
SakshiKekre wants to merge 1 commit intomainfrom
Open
feat: Expose parameter_nodes property on TaxBenefitModelVersion#254SakshiKekre wants to merge 1 commit intomainfrom
SakshiKekre wants to merge 1 commit intomainfrom
Conversation
SakshiKekre
added a commit
to PolicyEngine/policyengine-api-v2-alpha
that referenced
this pull request
Mar 10, 2026
Add ParameterNode model and migration to store folder structure labels for the parameter tree (e.g., "HMRC" instead of "hmrc"). Changes: - Add ParameterNode SQLModel with name, label, description fields - Add Alembic migration for parameter_nodes table - Update seed_models.py to seed nodes from policyengine.py - Update /parameters/children to use node labels from DB Requires: PolicyEngine/policyengine.py#254
Add ParameterNode class and expose parameter_nodes list from TaxBenefitModelVersion. This allows the API to seed folder/category labels (e.g., "HMRC" instead of "hmrc") for the parameter tree. Changes: - Add src/policyengine/core/parameter_node.py - Update TaxBenefitModelVersion with parameter_nodes list and lookup - Update UK and US models to populate parameter_nodes from CoreParameterNode 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SakshiKekre
force-pushed
the
feat/parameter-nodes
branch
from
66d2052 to
8b365f3
Compare
SakshiKekre
added a commit
to PolicyEngine/policyengine-api-v2-alpha
that referenced
this pull request
Mar 11, 2026
Add ParameterNode model and migration to store folder structure labels for the parameter tree (e.g., "HMRC" instead of "hmrc"). Changes: - Add ParameterNode SQLModel with name, label, description fields - Add Alembic migration for parameter_nodes table - Update seed_models.py to seed nodes from policyengine.py - Update /parameters/children to use node labels from DB Requires: PolicyEngine/policyengine.py#254
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParameterNodeclass to represent folder/category nodes in the parameter treeparameter_nodeslist onTaxBenefitModelVersionparameter_nodesfromCoreParameterNodeobjectsThis allows the API to seed proper labels for parameter folder nodes (e.g., "HMRC" instead of "hmrc").
Test plan
uk_latest.parameter_nodesreturns nodes with labelsus_latest.parameter_nodesreturns nodes with labels