Add performance harness binary and server module to automation backend#3
Merged
HarishKarthickS merged 8 commits intoPollux-Studio:mainfrom Mar 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves how the automation backend detects and handles explicit paths to the WebView2 browser executable (msedgewebview2.exe). It introduces a is_webview2_executable_path helper to identify the executable by filename, updates browser_launch_targets to return a webview2 runtime target when such a path is configured, and updates preferred_browser_runtime_name to prioritize webview2 in that case.
Changes:
- Added
is_webview2_executable_pathhelper function (duplicated in bothserver.rsandperf-harness.rs) to detect the WebView2 binary by filename. - Updated
browser_launch_targetsin both files to short-circuit with awebview2target when an explicit path tomsedgewebview2.exeis configured and the file exists. - Updated
preferred_browser_runtime_nameinserver.rsand added/extended tests in both files for the new detection logic.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
backend/automation/src/server.rs |
Adds is_webview2_executable_path, updates browser_launch_targets and preferred_browser_runtime_name, adds new test |
backend/automation/src/bin/perf-harness.rs |
Adds is_webview2_executable_path, updates browser_launch_targets, extends existing test with WebView2 case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ust performance harness.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ser, and terminal operations.
…maxc into feature/backend
… with synthetic and real-runtime modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how the backend detects and handles explicit paths to the WebView2 browser executable. It introduces a helper function to recognize the
msedgewebview2.exebinary and updates the browser launch logic to correctly map such paths to thewebview2runtime. Additionally, it refines the runtime selection logic and adds a dedicated test for this scenario.WebView2 executable detection and launch logic:
is_webview2_executable_pathhelper function to reliably identify the WebView2 executable by filename.browser_launch_targetsto return awebview2runtime target when an explicit path tomsedgewebview2.exeis configured.Runtime selection logic:
preferred_browser_runtime_nameto prioritize thewebview2runtime if the configuration points towebview2or its executable path.Testing:
msedgewebview2.exeresults in the correct runtime mapping.