Skip to content

Conversation

@walkerbdev
Copy link
Member

No description provided.

chg = valtochg.get(val, 0)
# special case of polar neighbors surrounding carbon or nitrogen
# https://docs.eyesopen.com/toolkits/cpp/oechemtk/valence.html
# https://www.masterorganicchemistry.com/2011/03/11/3-factors-that-stabilize-carbocations/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rather long article. If there is a specific sub-section that is relevant to this code, then please cite the specific sub-section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have added the text "Factors That Stabilize Carbocations – Adjacent Lone Pairs" but the addition of that text doesn't necessarily indicate to the reader that you are attempting to cite a specific section. The article has numbered sections, so you should cite the section number: For example:
See Section 6: Factors That Stabilize Carbocations – Adjacent Lone Pairs

Copy link
Contributor

@Nicholas-Schaub Nicholas-Schaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicholas-Schaub Nicholas-Schaub merged commit d4a7c61 into PolusAI:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants