feat: Add "Save to Workspace" feature#2
Merged
sunnielyu merged 17 commits intoPolusAI:masterfrom Jan 30, 2026
Merged
Conversation
- Updated `getURIDirectory` and `mountExploreUrl` functions to accept an `includeAppRoot` parameter for better control over URL prefixes. - Modified `ResultSet` and `Chart` components to utilize the new URL handling, allowing for relative URLs in React Router navigation and full URLs for new window openings.
- Updated `assetUrl` function to handle null or undefined paths, defaulting to '/'. - Enhanced `ensureStaticPrefix` function to return an empty string for falsy inputs. - Improved `ensureAppRoot` function to handle null or undefined paths similarly.
1a9439d to
a09f7bb
Compare
sunnielyu
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/work/)Changes
New Files
superset/commands/sql_lab/save_to_workspace.py- Backend command with sanitization and progress trackingsuperset-frontend/src/SqlLab/components/SaveToWorkspaceModal/index.tsx- React modal componentModified Files
superset/sqllab/api.py- Added save_to_workspace and progress endpointssuperset/sqllab/schemas.py- Added request/response schemassuperset-frontend/src/SqlLab/components/ResultSet/index.tsx- Added modal integration and buttonUsage
After running a SQL query, users click "Save to Workspace" to configure filename/subfolder and save to
~/work/.