feat: add integral context to RLCR review prompts#81
Merged
SihaoLiu merged 1 commit intoPolyArch:devfrom Apr 15, 2026
Merged
Conversation
f612fb3 to
2474513
Compare
Contributor
|
@codex please review this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 247451343f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Feed accumulated commit history and recent round summaries/reviews to Codex during each review round, completing the PID feedback model: - P (proportional): goal-tracker vs acceptance criteria - I (integral): accumulated commits + last 3 rounds history - D (derivative): current round summary vs prompt Validate BASE_COMMIT with cat-file -e before git log to prevent set -e crash on corrupted/stale state files. Add test-commit-history-section.sh covering all edge cases (9/9 pass). Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
2474513 to
c4389bb
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BASE_COMMITwithcat-file -ebeforegit logto preventset -ecrash on corrupted state files; annotate fallback when base commit is unavailableChanges
prompt-template/codex/commit-history-section.mdhooks/loop-codex-stop-hook.shprompt-template/codex/regular-review.md{{COMMIT_HISTORY_SECTION}}between summary and Part 1prompt-template/codex/full-alignment-review.mdtests/test-commit-history-section.shPID Model
Test plan
(no commits yet)and(first round, no prior history)✓base_commit: hook does not crash, falls back with(base commit unavailable, showing recent branch commits)annotation ✓All 9/9 tests pass (
tests/test-commit-history-section.sh).