Skip to content

Deprecate normalizer #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jecisc merged 2 commits into from
Apr 11, 2023
Merged

Deprecate normalizer #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52efca3
Do not add #defaultNormalizer when we already have #defaultNormalizer…
jecisc Apr 7, 2023
8116241
Deprecate #normalized
jecisc Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/DataFrame/DataFrame.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,6 @@ Class {
#category : #'DataFrame-Core'
}

{ #category : #defaults }
DataFrame class >> defaultNormalizer [

^ AIMinMaxNormalizer
]

{ #category : #'instance creation' }
DataFrame class >> new: aPoint [

Expand Down Expand Up @@ -1366,11 +1360,11 @@ DataFrame >> normalized [
"This methods returns a new DataFrame, without altering this one, that has all the columns normalized."

| normalizers normalizedColumns |
normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizer new ].
self deprecated:
'DataFrame will remove the dependency over normalization in the next version. You can use pharo-ai/data-preprocessing project to normalize your DataFrame and even more!'.
normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizerClass new ].

normalizedColumns := self columns
with: normalizers
collect: [ :col :normalizer | col normalizedUsing: normalizer ].
normalizedColumns := self columns with: normalizers collect: [ :col :normalizer | col normalizedUsing: normalizer ].

^ self class withColumns: normalizedColumns columnNames: self columnNames
]
Expand Down