Added DataFrame>> #replaceNilsWithNextRowValue #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have a hard time to think about a case were the user would prefer that to replacing by a constant, the average, the mean or another statistic. But it does not cost a lot to have so we can add it yes |
jecisc
reviewed
May 16, 2023
Comment on lines
+1801
to
+1805
| 1 to: self numberOfColumns do: [ :i | | ||
| self numberOfRows to: 1 by: -1 do: [ :j | | ||
| j < numberOfRows ifTrue: [ | ||
| (self at: j at: i) ifNil: [ self at: j at: i put: value ] ]. | ||
| value := self at: j at: i ] ] |
Member
There was a problem hiding this comment.
I prefer to use #columnIndex and #rowIndex as variable name for readability.
But this is just a detail :)
jecisc
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of pandas.ffils().
Tests have also been written for this method.
This is a fix for issue #221