Added DataFrame>> #toMarkdown along with tests#246
Merged
jecisc merged 2 commits intoPolyMathOrg:masterfrom Jun 1, 2023
Merged
Added DataFrame>> #toMarkdown along with tests#246jecisc merged 2 commits intoPolyMathOrg:masterfrom
jecisc merged 2 commits intoPolyMathOrg:masterfrom
Conversation
jecisc
reviewed
Jun 1, 2023
| " Prints the DataFrame as a Markdown formatted table" | ||
|
|
||
| | markdown columnWidths | | ||
| self addColumn: self rowNames named: '#' atPosition: 1. |
Member
There was a problem hiding this comment.
Should we act on the receiver? Shouldn't we copy the dataframe? Because here I have the impression that calling this method will change the original data frame and I don't think this is what we want.
Collaborator
Author
There was a problem hiding this comment.
Yes you are right, I made the changes.
jecisc
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented a method
toMarkdownso that DataFrames can be converted to a Markdown formatted table.This should return a string which can be copy-pasted in an editor which supports Markdown.
It would look like this once this text is pasted in a Markdown supported editor :