Skip to content

Fixed #267. #asDataFrame now retains the collection elements data types. #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jecisc merged 3 commits into from
Jun 27, 2023
Merged

Fixed #267. #asDataFrame now retains the collection elements data types. #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43f1f9b
Fixed #267. #asDataFrame now retains original data types.
Joshua-Dias-Barreto Jun 23, 2023
822ae9d
Added a regression test so that #asDataFrame retains original data ty…
Joshua-Dias-Barreto Jun 23, 2023
052482b
Merge branch 'PolyMathOrg:master' into chainedSorting
Joshua-Dias-Barreto Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/DataFrame-Tests/DataFrameTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,21 @@ DataFrameTest >> testAsDataFrame [
self assert: actual equals: expected
]

{ #category : #tests }
DataFrameTest >> testAsDataFrameDataTypes [

| actual expected |
actual := #( #( a 1 3.1 )
#( b 2 6.5 )
#( c 3 9.7 ) ) asDataFrame dataTypes.
expected := Dictionary newFrom: {
(1 -> Object).
(2 -> SmallInteger).
(3 -> SmallFloat64) }.

self assert: actual equals: expected
]

{ #category : #tests }
DataFrameTest >> testAsDataFrameEmpty [

Expand Down
5 changes: 4 additions & 1 deletion src/DataFrame/Collection.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ Collection >> asDataFrame [
| value |
value := row at: colIndex ifAbsent: [ nil ].
dataFrame at: rowIndex at: colIndex put: value ] ].

1 to: numberOfColumns do: [ :colIndex |
dataFrame dataTypes
at: colIndex
put: (dataFrame columnAt: colIndex) calculateDataType ].

^ dataFrame
]
Expand Down