Addition of class and operations on tensors #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
PMTensorRank2 was a test, can you commit only PMTensorRank and tests? |
Contributor
Author
|
In this pull request I integrated the classes
|
Member
|
Can you remove PMTensorRank2 and PMTensorRank2Test in your PR? |
SergeStinckwich
changed the title
SergeStinckwich
requested changes
Jul 26, 2021
SergeStinckwich
requested changes
Jul 26, 2021
khinsen
requested changes
Jul 26, 2021
khinsen
left a comment
khinsen
left a comment
There was a problem hiding this comment.
This looks very good overall, except for same name choices that could be improved.
Addition of the PMArray class replacing PMTensor
Addition of the PMArrayTest class replacing PMTensorTest
Member
|
@YvanGuifo there is still some changes (6) requested. Can you fix them, so I can accept the PR? |
SergeStinckwich
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.