Skip to content

Fixed #246. Refactored the PMComplexTest >> testComplexConjugate #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olekscode merged 1 commit into from
Apr 23, 2022
Merged

Fixed #246. Refactored the PMComplexTest >> testComplexConjugate #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Math-Tests-Complex/PMComplexTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,8 @@ PMComplexTest >> testComplexCollection [

{ #category : #tests }
PMComplexTest >> testComplexConjugate [
| z complexConjugateOfZ expected |
Copy link
Contributor

@hemalvarambhia hemalvarambhia Apr 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider giving the category a better name, perhaps testing - arithmetic (is complexConjugate in that category?).

Copy link
Member Author

@olekscode olekscode Apr 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a good idea to have descriptive categories
I will merge this one and then we will fix all categories in PMComplex

z := 5 - 6 i.

complexConjugateOfZ := z complexConjugate .

expected := 5 + 6 i.
self assert: complexConjugateOfZ equals: expected.

self assert: (5 - 6i) complexConjugate equals: (5 + 6i).
]

{ #category : #'testing - equality' }
Expand Down