Fixed #247. Added complexConjugate to Number and removed isCompleConjugateOf: #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sCompleConjugateOf:
hemalvarambhia
previously approved these changes
Apr 23, 2022
Contributor
|
This is better. Those tests you deleted didn't seem useful and were not well named. The coverage has gone down. Do check whether the loss represents something significant before merging. |
hemalvarambhia
dismissed
their stale review
I think Number already has complexConjugate
hemalvarambhia
approved these changes
Apr 23, 2022
| { #category : #'*Math-Complex' } | ||
| Number >> complexConjugate [ | ||
| ^ self. | ||
| "The complex conjugate of a complex number (a + bi) is another complex number (a - bi). |
Contributor
There was a problem hiding this comment.
I wouldn't have added the comment here and instead used tests to document this (Tests as Documentation). I would only comment on a design decision I made, the why, if you will. I suspect you did this because not all developers are familiar with concepts from mathematics. Is that right?
The part of about a real number being its own complex conjugate is a test already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ugateOf: