Skip to content

fixed issue when receiving invalid version when checking for mod updates #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoonlitJolteon merged 1 commit into from
Feb 4, 2021
Merged

fixed issue when receiving invalid version when checking for mod updates #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ParseClasses.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,21 @@ public class Release

public System.Version GetVersion()
{
System.Version version;
string parsed = this.tag_name.ToLower().Replace("v", "");
return new System.Version(parsed);
int pos;
pos = parsed.IndexOf("-");
if (pos != -1) parsed = parsed.Substring(0, pos);
pos = parsed.IndexOf("+");;
if (pos != -1) parsed = parsed.Substring(0, pos);
try {
version = new System.Version(parsed);
}
catch (FormatException ex){
PolyTechMain.ptfInstance.ptfLogger.LogError("Invalid Version found while checking for mod updates, using fallback value 0.0.0");
version = new System.Version("0.0.0");
}
return version;
}
}

Expand Down
2 changes: 1 addition & 1 deletion PolyTechMain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class PolyTechMain : PolyTechMod
public new const string
PluginGuid = "polytech.polytechframework",
PluginName = "PolyTech Framework",
PluginVersion = "0.9.1";
PluginVersion = "0.9.2";
private static BindingList<PolyTechMod>
noncheatMods = new BindingList<PolyTechMod> { },
cheatMods = new BindingList<PolyTechMod> { };
Expand Down