Skip to content

add: multi verify server#88

Merged
quantumshiro merged 14 commits intodevelopfrom
feature/multi_sig
Jun 2, 2025
Merged

add: multi verify server#88
quantumshiro merged 14 commits intodevelopfrom
feature/multi_sig

Conversation

@quantumshiro
Copy link
Copy Markdown
Member

複数暗合方式に対応しました

@quantumshiro quantumshiro self-assigned this Jun 1, 2025
@quantumshiro quantumshiro requested review from Copilot and iokira June 1, 2025 15:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for multiple signature schemes (ECDSA and FNDSA) end‐to‐end by tagging wallets and addresses with an encryption type and selecting the right crypto provider for signing and verification.

  • Wallets now carry an encryption_type, append a suffix to addresses, and expose extract_encryption_type
  • Server and CLI routes use the suffix to pick ECDSA or FNDSA for signing
  • Transactions detect the scheme from public-key size during verification

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/network/server.rs Extracts scheme from address, picks corresponding CryptoProvider to sign
src/crypto/wallets.rs Added encryption_type in Wallet, address suffix, and extractor
src/crypto/types.rs Introduces EncryptionType (and unused DecryptionType) enums
src/crypto/transaction.rs Implements determine_encryption_type and branches verify logic
src/crypto.rs Adds get_crypto_provider factory
src/command/cli.rs Uses wallet’s encryption_type for CLI commands and strip suffix
Comments suppressed due to low confidence (3)

src/crypto/wallets.rs:23

  • Tests call Wallet::default(), but after adding the encryption_type field the Default impl is missing or incomplete. Consider providing a manual impl Default for Wallet that initializes encryption_type.
pub struct Wallet {

src/crypto/transaction.rs:31

  • Clean up these leftover commented lines in the verify logic for clarity now that determine_encryption_type is implemented.
// if pub_key.len() <= 65 {

src/crypto/types.rs:9

  • The DecryptionType enum is introduced but never used. Consider removing it to avoid unused code.
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]

Comment thread src/network/server.rs Outdated
Comment thread src/crypto/wallets.rs Outdated
Comment thread src/crypto/wallets.rs Outdated
Comment thread src/crypto/wallets.rs Outdated
quantumshiro and others added 6 commits June 2, 2025 00:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread .github/workflows/coverage-llvm-cov.yml Fixed
Comment thread .github/workflows/coverage-tarpaulin.yml Fixed
Comment thread .github/workflows/coverage.yml Fixed
quantumshiro and others added 5 commits June 2, 2025 12:33
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2025

📊 Code Coverage Report

✅ Coverage data has been generated successfully

Artifacts:

  • 📄 LCOV Report: coverage.lcov
  • 📁 HTML Report: coverage-html/

View detailed coverage:

  1. Download the HTML artifact from this run
  2. Extract and open index.html in your browser

Coverage reports are also uploaded to Codecov and Coveralls (if configured)

@quantumshiro quantumshiro merged commit 64c7fa5 into develop Jun 2, 2025
4 checks passed
@quantumshiro quantumshiro deleted the feature/multi_sig branch June 2, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants