Skip to content

chore(issuer): ensure that the whitelist date is in YYYY format#497

Merged
RafaelVidaurre merged 4 commits intodevelopfrom
chore/whitelist-date-validator
Apr 1, 2019
Merged

chore(issuer): ensure that the whitelist date is in YYYY format#497
RafaelVidaurre merged 4 commits intodevelopfrom
chore/whitelist-date-validator

Conversation

@sajclarke
Copy link
Copy Markdown
Contributor

Please make sure the following boxes are checked before submitting your Pull Request:

  • I've added this PR's link to its Asana task(s)
  • If this PR adds new code that is not going to change in the near future, it includes unit tests to cover it.

@RafaelVidaurre
Copy link
Copy Markdown
Contributor

@sajclarke tests failing on this one 🙏

Copy link
Copy Markdown
Contributor

@RafaelVidaurre RafaelVidaurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing

Comment thread packages/polymath-issuer/src/utils/parsers/index.js Outdated
@sajclarke
Copy link
Copy Markdown
Contributor Author

Tests failing

Resolved

@Grsmto
Copy link
Copy Markdown
Contributor

Grsmto commented Mar 25, 2019

LGTM guys @RafaelVidaurre should we merge this?

Comment thread packages/polymath-issuer/src/utils/parsers/index.js Outdated
@RafaelVidaurre
Copy link
Copy Markdown
Contributor

@sajclarke got some conflicts on this one

@RafaelVidaurre RafaelVidaurre merged commit 6f0d65e into develop Apr 1, 2019
@RafaelVidaurre RafaelVidaurre deleted the chore/whitelist-date-validator branch April 1, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants